fix: add additionalProperties:false to schema + clean non-standard fields#62
Merged
ningzimu merged 1 commit intoMLT-OSS:mainfrom Mar 16, 2026
Merged
Conversation
…-standard fields - Remove non-schema fields from china-lcd-association, dosm, bank-of-england-statistics, unfpa-urbanization - Add additionalProperties: false to datasource-schema.json - All 260 data source files pass validation Closes MLT-OSS#61
Collaborator
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. schema 加 additionalProperties:false + 清理 4 个非标文件，从根本上防住非标字段问题。建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
additionalProperties: falsetodatasource-schema.json— CI will now reject files with non-schema fieldschina-lcd-association.json: removed$schemadosm.json: removedcontact,data_formatsbank-of-england-statistics.json: removeddata_access,metadata,organization,support,temporal_coverage,update_frequency_notesunfpa-urbanization.json: removedaccess,formats,organization,related_links✅ All 260 data source files pass validation
Closes #61